Repository navigation
Remove the disused selectLimit metadata query - #462
Conversation
gibson9583
left a comment
gibson9583
left a comment
There was a problem hiding this comment.
Please address items I left in line
|
@gibson9583, I don't see a clean way to leave a @pacmano1 / @tonygermano, you were the original requestor on selectLimit being removed. Can you comment? I'm fine with the status quo in main. |
NicoPiel
left a comment
NicoPiel
left a comment
There was a problem hiding this comment.
non-blocking:
- Plugins built against the old interface: removes this parameter on purpose, and the server was already ignoring it. A third-party plugin would only break if it called
getTablesitself, which is unlikely. A line in the release notes covers it. new DriverInfo(a, b, c, null)no longer compiling: nothing in the repo calls it that way. Outside code would get a clear compile error, not a runtime failure, and casting thenullfixes it.
@mgaffigan What I had intended with my original suggestion was something like // original api method with selectLimit
@deprecated
public SortedSet<Table> getTables(String channelId, String channelName, String driver,
String url, String username, String password, Set<String> tableNamePatterns, String selectLimit,
Set<String> resourceIds) {
return getTables(channelId, channelName, driver, url, username, password, tableNamePatterns, resourceIds);
}
// new api method without selectLimit
public SortedSet<Table> getTables(String channelId, String channelName, String driver,
String url, String username, String password, Set<String> tableNamePatterns, Set<String> resourceIds) {
// implementation without selectLimit
}Does your response to @gibson9583 say this is not possible with the client? |
Yes. That's what I went for originally, but I ran into problems with the RPC magic. |
tonygermano
left a comment
tonygermano
left a comment
There was a problem hiding this comment.
@gibson9583, a deprecated getTables overload would need changes to the client proxy plumbing that every servlet interface uses (Client.getServlet rejects methods without JAX-RS annotations), just to keep an already-ignored parameter alive. Instead, 4.7.0 keeps the parameter but ignores it, and its release notes announce that it's deprecated and will be removed in an upcoming release (#503). This PR completes that cycle.
Older client-core jars keep working against newer servers, since the server ignores the extra query parameter. The new jar works against older servers too. The break is limited to upgrading the jar, which is a one-argument compile error.
@mgaffigan, I added a "Release note" section to the PR description announcing the removal. Feel free to adjust the wording.
Drafted with Claude Code
Dismissed at the review author’s request.
Dead since the table metadata probe switched to `WHERE 1 = 0`. Dropped the REST parameter, the Drivers dialog column, and the dbdrivers.xml attribute. `DriverInfo.selectLimit` is retained as a deprecated no-op: the field still has to exist for previously saved driver lists to deserialize, and the constructors keep outside callers building. It no longer participates in equals, so the dialog does not report a phantom change when loading an old config. Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
cc5f17a to
fdff780
Compare
fdff780
into
OpenIntegrationEngine:main
Dead since the table metadata probe switched to
WHERE 1 = 0. Dropped the REST parameter, the Drivers dialog column, and the dbdrivers.xml attribute.DriverInfo.selectLimitis retained as a deprecated no-op: the field still has to exist for previously saved driver lists to deserialize, and the constructors keep outside callers building. It no longer participates in equals, so the dialog does not report a phantom change when loading an old config.Parameter can be removed without breaking users - extra parameters are ignored. I can't find any plugins that use the call directly, and it doesn't seem likely that one would, so that parameter was dropped without a deprecated overload.
Closes #461
Release note
The deprecated
selectLimitparameter has been removed fromPOST /connectors/jdbc/_getTablesandDatabaseConnectorServletInterface.getTables. Java code callinggetTablesthrough client-core must drop that argument. Custom "Select with Limit Query" values are no longer shown in the Database Drivers settings or read fromdbdrivers.xml.